[PATCH] Replace loop variable naming logic

Dmitri Gribenko gribozavr at gmail.com
Fri Mar 1 11:58:34 PST 2013


  Sorry, but I have a good reason to disagree.  Iterators are usually named 'i', 'j', 'it', 'iter' to suggest that they are *iterators*, not the actual data.  After loop conversion this is no longer the case.  But I agree that we have an issue with containers that are named like a language keyword.  There's also an issue with inventing a new name -- it could be a macro.

  So I think that the proposed mode should be:
  * enabled when the new name is a macro or a keyword;
  * enabled with an extra option.

http://llvm-reviews.chandlerc.com/D484



More information about the cfe-commits mailing list