Better support for constructors with -cxx-abi microsoft

[Timur Iskhodzhanov]

[bcc: llvm-commits, cc: cfe-commits]

2013/2/25 Timur Iskhodzhanov <timurrrr at google.com>:
> Hi John,
>
> Attached is a preliminary patch for ctors in -cxx-abi microsoft.
>
> It adds:
> - support for out-of-class constructor definitions (PR12784),
> - reading and writing proper ctor arguments when dealing with virtual bases.
> I also tried this patch on some "build, run and verify" tests for
> virtual inheritance vs ctors and it works great.
>
> Can you please take a look at the implementation and tell me if there
> are any logical mistakes?
>
> Also, I've put two TODOs in the code with questions.
> It would be nice if you could take a look at the logic first and
> suggest me if my CGCXXABI abstraction plans are sane - before I copy
> any code between files.
>
> If the logic of the patch and the abstraction suggestions are fine,
> I'll move the code around as described and prepare a patch ready for
> review.
>
> Thanks!
> --
> Timur
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ctors.patch
Type: application/octet-stream
Size: 11953 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130225/8c7d546e/attachment.obj>