r175982 - PR15338: Don't assert if -fsanitize=bounds sees array indexing on an incomplete

Richard Smith richard at metafoo.co.uk
Sat Feb 23 19:11:40 PST 2013


On Sat, Feb 23, 2013 at 6:39 PM, Sean Silva <silvas at purdue.edu> wrote:

> -      else if (const VariableArrayType *VAT = cast<VariableArrayType>(AT))
>
> Isn't this tautological? I thought that cast<> required its argument
> to be nonnull (and hence this would always be true (or otherwise UB)).
> If not, then the existence of cast_or_null<> seems suspect.


Yes, it was supposed to be a dyn_cast. That's the bug this change fixed.

>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130223/1c00ee45/attachment.html>


More information about the cfe-commits mailing list