[PATCH] Add user documentation for cpp11-migrate

Dmitri Gribenko gribozavr at gmail.com
Fri Feb 22 12:46:08 PST 2013


  LGTM with above comments.


================
Comment at: docs/cpp11-migrate.rst:6
@@ +5,3 @@
+:program:`cpp11-migrate` is a standalone tool used to automatically convert
+traditional C++ code to use features of the new C++11 standard where
+appropriate.
----------------
s/traditional/C++98 and C++03/

================
Comment at: docs/cpp11-migrate.rst:17-18
@@ +16,4 @@
+
+Command Line Options
+--------------------
+
----------------
It might be a good idea to split this list into two: general options and options that enable specific migrations, or just reorder them so that conversions appear first... But it is sorted alphabetically -- and that makes sense, so you can probably leave it as it is.

================
Comment at: docs/cpp11-migrate.rst:82-83
@@ +81,4 @@
+
+Loop convert is a transformation to convert traditional ``for`` loops to use the
+new range-based loops in C++11.
+
----------------
"Plain for loops"?  "for(...; ...; ...) loops?"  This is not a tradition or some kind of legacy syntax, this is just the only kind of for C++98 had.

================
Comment at: docs/cpp11-migrate.rst:124
@@ +123,3 @@
+be converted if the acceptable risk level is set to ``-risk=reasonable``
+(implicit) or higher.
+
----------------
s/implicit/default/

================
Comment at: docs/cpp11-migrate.rst:133
@@ +132,3 @@
+
+  // using .size() is considered reasonable
+  for (int i = 0; i < v.size(); ++i)
----------------
It is not clear if this is only for std::vectors or in general for member functions with the name `size`.


http://llvm-reviews.chandlerc.com/D453

BRANCH
  jiayiyan

ARCANIST PROJECT
  clang-tools-extra



More information about the cfe-commits mailing list