r175812 - Replace ProgramPoint llvm::cast support to be well-defined.

David Blaikie dblaikie at gmail.com
Thu Feb 21 15:37:04 PST 2013


On Thu, Feb 21, 2013 at 3:27 PM, Jordan Rose <jordan_rose at apple.com> wrote:

>
> On Feb 21, 2013, at 14:23 , David Blaikie <dblaikie at gmail.com> wrote:
>
> +  /// \brief Convert to the specified TypeLoc type, asserting that this
> TypeLoc
> +  /// is of the desired type.
>
>
> s/TypeLoc/ProgramPoint/? (Was this in the last one as well?)
>

r175825 & no, seems I correctly updated the copy/pasted comment in CFG.h
before committing


> -  const CallExitEnd *CExit = dyn_cast<CallExitEnd>(&P);
>
> +  Optional<CallExitEnd> CExit = P.getAs<CallExitEnd>();
>   assert(CExit && "Stack Hints should be constructed at CallExitEnd
> points.");
>
>
> Despite the assert message, this should probably just use castAs to get
> better Release build code.
>

 r175826

Thanks!
- David
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130221/8f242518/attachment.html>


More information about the cfe-commits mailing list