r175784 - Try to get buildbots to pass these tests.

Renato Golin renato.golin at linaro.org
Thu Feb 21 14:58:11 PST 2013


Hi Bill,

I hope I got them all right... Tried to follow what the test was doing... ;)

--renato


On 21 February 2013 22:48, Bill Wendling <isanbard at gmail.com> wrote:

> Hi Renato,
>
> Could you get me the output of the CodeGen/address-safety-attr.cpp file
> for all three RUN lines? That would help me figure what's going on here...
>
> -bw
>
> On Feb 21, 2013, at 2:31 PM, Renato Golin <renato.golin at linaro.org> wrote:
>
> > Hi Bill,
> >
> > Thanks for the changes, we're almost there... ;)
> >
> >
> http://lab.llvm.org:8011/builders/clang-native-arm-cortex-a9/builds/5339/steps/check-all/logs/Clang%20%3A%3A%20CodeGen__address-safety-attr.cpp
> >
> > cheers,
> > --renato
> >
> > PS: I'm trying to come up with a plan where people can test on ARM
> devices directly to avoid this kind of iteration, but security concerns
> (and my lack of white hat ability) are delaying any concrete plans to do
> it. I thought about something like the test page we used to have on
> llvm.org, but on ARM. Ideas welcome.
> >
> >
> > On 21 February 2013 19:44, Bill Wendling <isanbard at gmail.com> wrote:
> > Author: void
> > Date: Thu Feb 21 13:44:18 2013
> > New Revision: 175784
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=175784&view=rev
> > Log:
> > Try to get buildbots to pass these tests.
> >
> > Modified:
> >     cfe/trunk/test/CXX/special/class.dtor/p3-0x.cpp
> >     cfe/trunk/test/CodeGen/address-safety-attr.cpp
> >
> > Modified: cfe/trunk/test/CXX/special/class.dtor/p3-0x.cpp
> > URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CXX/special/class.dtor/p3-0x.cpp?rev=175784&r1=175783&r2=175784&view=diff
> >
> ==============================================================================
> > --- cfe/trunk/test/CXX/special/class.dtor/p3-0x.cpp (original)
> > +++ cfe/trunk/test/CXX/special/class.dtor/p3-0x.cpp Thu Feb 21 13:44:18
> 2013
> > @@ -176,4 +176,4 @@ struct TVC : VX
> >  template <typename T>
> >  TVC<T>::~TVC() {}
> >
> > -// CHECK: attributes [[ATTRGRP]] = { nounwind "target-features"={{.*}} }
> > +// CHECK: attributes [[ATTRGRP]] = { nounwind{{.*}} }
> >
> > Modified: cfe/trunk/test/CodeGen/address-safety-attr.cpp
> > URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/address-safety-attr.cpp?rev=175784&r1=175783&r2=175784&view=diff
> >
> ==============================================================================
> > --- cfe/trunk/test/CodeGen/address-safety-attr.cpp (original)
> > +++ cfe/trunk/test/CodeGen/address-safety-attr.cpp Thu Feb 21 13:44:18
> 2013
> > @@ -47,12 +47,15 @@ int force_instance = TemplateAddressSafe
> >  // Check that __cxx_global_var_init* get the address_safety attribute.
> >  int global1 = 0;
> >  int global2 = *(int*)((char*)&global1+1);
> > -// WITHOUT: @__cxx_global_var_init{{.*}}#1
> > -// BL: @__cxx_global_var_init{{.*}}#1
> > -// ASAN: @__cxx_global_var_init{{.*}}#2
> > +// WITHOUT: @__cxx_global_var_init{{.*}}#[[GVI:[0-9]+]]
> > +// BL: @__cxx_global_var_init{{.*}}#[[GVI:[0-9]+]]
> > +// ASAN: @__cxx_global_var_init{{.*}}#[[GVI:[0-9]+]]
> >
> > -// WITHOUT: attributes #[[NOATTR]] = { nounwind
> "target-features"={{.*}} }
> > -// BL: attributes #[[NOATTR]] = { nounwind "target-features"={{.*}} }
> > +// WITHOUT: attributes #[[NOATTR]] = { nounwind{{.*}} }
> > +// WITHOUT: attributes #[[GVI]] = { nounwind{{.*}} }
> > +// BL: attributes #[[NOATTR]] = { nounwind{{.*}} }
> > +// BL: attributes #[[GVI]] = { nounwind{{.*}} }
> >
> > -// ASAN: attributes #[[NOATTR]] = { nounwind "target-features"={{.*}} }
> > -// ASAN: attributes #[[WITH]] = { address_safety nounwind
> "target-features"={{.*}} }
> > +// ASAN: attributes #[[NOATTR]] = { nounwind{{.*}} }
> > +// ASAN: attributes #[[WITH]] = { address_safety nounwind{{.*}} }
> > +// ASAN: attributes #[[GVI]] = { address_safety nounwind{{.*}} }
> >
> >
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> >
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130221/f9aed526/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: address-safety-attr.zip
Type: application/zip
Size: 3712 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130221/f9aed526/attachment.zip>


More information about the cfe-commits mailing list