[clang-tools-extra] r175744 - Fixing a "multiple rules generate X" warning from ninja

[David Blaikie]

On Thu, Feb 21, 2013 at 7:12 AM, Edwin Vane <edwin.vane at intel.com> wrote:

> Author: revane
> Date: Thu Feb 21 09:12:01 2013
> New Revision: 175744
>
> URL: http://llvm.org/viewvc/llvm-project?rev=175744&view=rev
> Log:
> Fixing a "multiple rules generate X" warning from ninja
>

Thanks, I've been wondering about that.

- David


>
> CMake's Ninja generator was not detecting that test/lit.site.cfg.in and
> test/subdir/../lit.site.cfg.in were really the same file. Ninja noticed
> this
> and complained as both appeared as targets (for the missing file rule). Now
> canonicalizing the path to ensure the paths presented to CMake are
> identical
> and the duplication is now fixed.
>
>
> Modified:
>     clang-tools-extra/trunk/test/cpp11-migrate/CMakeLists.txt
>
> Modified: clang-tools-extra/trunk/test/cpp11-migrate/CMakeLists.txt
> URL:
> http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/cpp11-migrate/CMakeLists.txt?rev=175744&r1=175743&r2=175744&view=diff
>
> ==============================================================================
> --- clang-tools-extra/trunk/test/cpp11-migrate/CMakeLists.txt (original)
> +++ clang-tools-extra/trunk/test/cpp11-migrate/CMakeLists.txt Thu Feb 21
> 09:12:01 2013
> @@ -53,7 +53,8 @@ add_custom_target(cpp11-migrate-autogen
>  set(TEST_SOURCE_ROOT ${CMAKE_CURRENT_BINARY_DIR}/generated_tests)
>  set(TEST_EXEC_ROOT ${CMAKE_CURRENT_BINARY_DIR})
>  set(TESTSUITE_NAME "cpp11-migrate Auto-Generated Tests")
> +get_filename_component(INPUT_LIT_CFG ${CMAKE_CURRENT_SOURCE_DIR}/../
> lit.site.cfg.in REALPATH)
>  configure_lit_site_cfg(
> -  ${CMAKE_CURRENT_SOURCE_DIR}/../lit.site.cfg.in
> +  ${INPUT_LIT_CFG}
>    ${CMAKE_CURRENT_BINARY_DIR}/generated_tests/lit.site.cfg
>    )
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130221/96600e19/attachment.html>