r175676 - Rename SVal::isType functions to SVal::isKind

David Blaikie dblaikie at gmail.com
Wed Feb 20 14:22:59 PST 2013


Author: dblaikie
Date: Wed Feb 20 16:22:59 2013
New Revision: 175676

URL: http://llvm.org/viewvc/llvm-project?rev=175676&view=rev
Log:
Rename SVal::isType functions to SVal::isKind

Post-commit CR feedback from Jordan Rose regarding r175594.

Modified:
    cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/SVals.h

Modified: cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/SVals.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/SVals.h?rev=175676&r1=175675&r2=175676&view=diff
==============================================================================
--- cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/SVals.h (original)
+++ cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/SVals.h Wed Feb 20 16:22:59 2013
@@ -71,7 +71,7 @@ public:
 
   template<typename T>
   T castAs() const {
-    assert(T::isType(*this));
+    assert(T::isKind(*this));
     T t;
     SVal& sv = t;
     sv = *this;
@@ -80,7 +80,7 @@ public:
 
   template<typename T>
   llvm::Optional<T> getAs() const {
-    if (!T::isType(*this))
+    if (!T::isKind(*this))
       return llvm::Optional<T>();
     T t;
     SVal& sv = t;
@@ -182,7 +182,7 @@ public:
 
 private:
   friend class SVal;
-  static bool isType(const SVal& V) {
+  static bool isKind(const SVal& V) {
     return V.getBaseKind() == UndefinedKind;
   }
 };
@@ -204,7 +204,7 @@ protected:
   
 private:
   friend class SVal;
-  static bool isType(const SVal& V) {
+  static bool isKind(const SVal& V) {
     return !V.isUndef();
   }
 };
@@ -215,7 +215,7 @@ public:
   
 private:
   friend class SVal;
-  static bool isType(const SVal& V) {
+  static bool isKind(const SVal& V) {
     return V.getBaseKind() == UnknownKind;
   }
 };
@@ -233,7 +233,7 @@ protected:
     : DefinedOrUnknownSVal(d, isLoc, ValKind) {}
 private:
   friend class SVal;
-  static bool isType(const SVal& V) {
+  static bool isKind(const SVal& V) {
     return !V.isUnknownOrUndef();
   }
 };
@@ -249,7 +249,7 @@ public:
 
 private:
   friend class SVal;
-  static bool isType(const SVal& V) {
+  static bool isKind(const SVal& V) {
     return V.getBaseKind() == NonLocKind;
   }
 };
@@ -270,7 +270,7 @@ public:
 
 private:
   friend class SVal;
-  static bool isType(const SVal& V) {
+  static bool isKind(const SVal& V) {
     return V.getBaseKind() == LocKind;
   }
 };
@@ -300,12 +300,12 @@ public:
 private:
   friend class SVal;
   SymbolVal() {}
-  static bool isType(const SVal& V) {
+  static bool isKind(const SVal& V) {
     return V.getBaseKind() == NonLocKind &&
            V.getSubKind() == SymbolValKind;
   }
 
-  static bool isType(const NonLoc& V) {
+  static bool isKind(const NonLoc& V) {
     return V.getSubKind() == SymbolValKind;
   }
 };
@@ -330,12 +330,12 @@ public:
 private:
   friend class SVal;
   ConcreteInt() {}
-  static bool isType(const SVal& V) {
+  static bool isKind(const SVal& V) {
     return V.getBaseKind() == NonLocKind &&
            V.getSubKind() == ConcreteIntKind;
   }
 
-  static bool isType(const NonLoc& V) {
+  static bool isKind(const NonLoc& V) {
     return V.getSubKind() == ConcreteIntKind;
   }
 };
@@ -372,12 +372,12 @@ public:
 private:
   friend class SVal;
   LocAsInteger() {}
-  static bool isType(const SVal& V) {
+  static bool isKind(const SVal& V) {
     return V.getBaseKind() == NonLocKind &&
            V.getSubKind() == LocAsIntegerKind;
   }
 
-  static bool isType(const NonLoc& V) {
+  static bool isKind(const NonLoc& V) {
     return V.getSubKind() == LocAsIntegerKind;
   }
 };
@@ -399,11 +399,11 @@ public:
 private:
   friend class SVal;
   CompoundVal() {}
-  static bool isType(const SVal& V) {
+  static bool isKind(const SVal& V) {
     return V.getBaseKind() == NonLocKind && V.getSubKind() == CompoundValKind;
   }
 
-  static bool isType(const NonLoc& V) {
+  static bool isKind(const NonLoc& V) {
     return V.getSubKind() == CompoundValKind;
   }
 };
@@ -423,11 +423,11 @@ public:
 private:
   friend class SVal;
   LazyCompoundVal() {}
-  static bool isType(const SVal& V) {
+  static bool isKind(const SVal& V) {
     return V.getBaseKind() == NonLocKind &&
            V.getSubKind() == LazyCompoundValKind;
   }
-  static bool isType(const NonLoc& V) {
+  static bool isKind(const NonLoc& V) {
     return V.getSubKind() == LazyCompoundValKind;
   }
 };
@@ -453,11 +453,11 @@ public:
 private:
   friend class SVal;
   GotoLabel() {}
-  static bool isType(const SVal& V) {
+  static bool isKind(const SVal& V) {
     return V.getBaseKind() == LocKind && V.getSubKind() == GotoLabelKind;
   }
 
-  static bool isType(const Loc& V) {
+  static bool isKind(const Loc& V) {
     return V.getSubKind() == GotoLabelKind;
   }
 };
@@ -491,12 +491,12 @@ public:
 private:
   friend class SVal;
   MemRegionVal() {}
-  static bool isType(const SVal& V) {
+  static bool isKind(const SVal& V) {
     return V.getBaseKind() == LocKind &&
            V.getSubKind() == MemRegionKind;
   }
 
-  static bool isType(const Loc& V) {
+  static bool isKind(const Loc& V) {
     return V.getSubKind() == MemRegionKind;
   }
 };
@@ -516,12 +516,12 @@ public:
 private:
   friend class SVal;
   ConcreteInt() {}
-  static bool isType(const SVal& V) {
+  static bool isKind(const SVal& V) {
     return V.getBaseKind() == LocKind &&
            V.getSubKind() == ConcreteIntKind;
   }
 
-  static bool isType(const Loc& V) {
+  static bool isKind(const Loc& V) {
     return V.getSubKind() == ConcreteIntKind;
   }
 };





More information about the cfe-commits mailing list