r175588 - intmax_t is long long on Darwin, not long.

Jordan Rose jordan_rose at apple.com
Tue Feb 19 17:56:21 PST 2013


Author: jrose
Date: Tue Feb 19 19:56:21 2013
New Revision: 175588

URL: http://llvm.org/viewvc/llvm-project?rev=175588&view=rev
Log:
intmax_t is long long on Darwin, not long.

<rdar://problem/11540697>

Modified:
    cfe/trunk/lib/Basic/Targets.cpp
    cfe/trunk/test/FixIt/format-darwin.m
    cfe/trunk/test/Sema/format-strings-size_t.c

Modified: cfe/trunk/lib/Basic/Targets.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Targets.cpp?rev=175588&r1=175587&r2=175588&view=diff
==============================================================================
--- cfe/trunk/lib/Basic/Targets.cpp (original)
+++ cfe/trunk/lib/Basic/Targets.cpp Tue Feb 19 19:56:21 2013
@@ -3119,6 +3119,8 @@ class DarwinX86_64TargetInfo : public Da
 public:
   DarwinX86_64TargetInfo(const std::string& triple)
       : DarwinTargetInfo<X86_64TargetInfo>(triple) {
+    IntMaxType = SignedLongLong;
+    UIntMaxType = UnsignedLongLong;
     Int64Type = SignedLongLong;
     MaxVectorAlign = 256;
   }

Modified: cfe/trunk/test/FixIt/format-darwin.m
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/FixIt/format-darwin.m?rev=175588&r1=175587&r2=175588&view=diff
==============================================================================
--- cfe/trunk/test/FixIt/format-darwin.m (original)
+++ cfe/trunk/test/FixIt/format-darwin.m Tue Feb 19 19:56:21 2013
@@ -21,6 +21,7 @@ typedef int NSInteger;
 typedef unsigned int NSUInteger;
 typedef long SInt32;
 typedef unsigned long UInt32;
+
 #endif
 
 NSInteger getNSInteger();
@@ -210,3 +211,25 @@ void testCapitals() {
   // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:13-[[@LINE-3]]:14}:"d"
   // CHECK: fix-it:"{{.*}}":{[[@LINE-4]]:11-[[@LINE-4]]:14}:"%D"
 }
+
+
+// The OS X headers do not always use __INTMAX_TYPE__ and friends.
+typedef long long intmax_t;
+typedef unsigned long long uintmax_t;
+#define INTMAX_C(X) (X ## LL)
+#define UINTMAX_C(X) (X ## ULL)
+
+void testIntMax(intmax_t i, uintmax_t u) {
+  printf("%d", i); // expected-warning{{format specifies type 'int' but the argument has type 'intmax_t' (aka 'long long')}}
+  printf("%d", u); // expected-warning{{format specifies type 'int' but the argument has type 'uintmax_t' (aka 'unsigned long long')}}
+
+  // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:11-[[@LINE-3]]:13}:"%jd"
+  // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:11-[[@LINE-3]]:13}:"%ju"
+
+  printf("%jd", i); // no-warning
+  printf("%ju", u); // no-warning
+
+  printf("%jd", INTMAX_C(5)); // no-warning
+  printf("%ju", INTMAX_C(5)); // no-warning
+}
+

Modified: cfe/trunk/test/Sema/format-strings-size_t.c
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Sema/format-strings-size_t.c?rev=175588&r1=175587&r2=175588&view=diff
==============================================================================
--- cfe/trunk/test/Sema/format-strings-size_t.c (original)
+++ cfe/trunk/test/Sema/format-strings-size_t.c Tue Feb 19 19:56:21 2013
@@ -1,4 +1,4 @@
-// RUN: %clang_cc1 -triple x86_64-apple-darwin10 -fsyntax-only -verify %s
+// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsyntax-only -verify %s
 
 int printf(char const *, ...);
 





More information about the cfe-commits mailing list