[Patch] OpenCL kernel-arg-info

[Benyei, Guy]

Pekka,
Thanks for the prompt review.

Attached an updated patch. Added a header file with the kKernelArgInfo specific enumerations.

Please review.

Thanks
    Guy

-----Original Message-----
From: Pekka Jääskeläinen [mailto:pekka.jaaskelainen at tut.fi] 
Sent: Sunday, February 17, 2013 18:23
To: Benyei, Guy
Cc: cfe-commits at cs.uiuc.edu
Subject: Re: [Patch] OpenCL kernel-arg-info

Hi,

You use "magic numbers" for the different address space ids.
Similarly the type qualifier bit masks could use some named consts, IMO.

These are from the SPIR specs, but still, using some sort of named constant/enum from a header file would clean it up.
There could be a header for the SPIR-specific constants?

The consumers for this metadata (at least the OpenCL
clGetKernelArgInfo() implementations) need to refer to these numbers too.

+      if(ty.isRestrictQualified())        typeQuals |= 2;
+      if(pointeeTy.isConstQualified())    typeQuals |= 1;
+      if(pointeeTy.isVolatileQualified()) typeQuals |= 4;

Some white space issues.

On 02/17/2013 04:49 PM, Benyei, Guy wrote:
> Please review.

--
--Pekka

---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: opencl_arg_info2.patch
Type: application/octet-stream
Size: 11409 bytes
Desc: opencl_arg_info2.patch
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130218/b151cd40/attachment.obj>