[PATCH] SPIR ABI and TargetCodeGenInfo

[Benyei, Guy]

Pekka,
The reason I didn't check the kernel ABIs is that it's the same for now as the non-kernel ABI. It's basically the default ABI: structs sent as pointers, all the rest by value.

Thanks
   Guy


-----Original Message-----
From: Pekka Jääskeläinen [mailto:pekka.jaaskelainen at tut.fi] 
Sent: Sunday, February 17, 2013 16:11
To: Benyei, Guy
Cc: cfe-commits at cs.uiuc.edu
Subject: Re: [PATCH] SPIR ABI and TargetCodeGenInfo

Hi,

You have only the trivial kernel test case for the SPIR_KERNEL CC in this patch.

Could you add more of the tricky kernel fingerprint cases similarly you have done for the device functions? Is everything going to be passed by pointers to the kernels in the SPIR_KERNEL CC?

On 02/17/2013 01:06 PM, Benyei, Guy wrote:
> Please review.


--
--Pekka

---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.