r174694 - Fix test failure by making sure this file isn't identical to any other file

Nick Lewycky nlewycky at google.com
Tue Feb 12 19:34:43 PST 2013


Good idea, done in r175027.


On 7 February 2013 19:19, Chandler Carruth <chandlerc at google.com> wrote:

> On Thu, Feb 7, 2013 at 6:38 PM, Nick Lewycky <nicholas at mxc.ca> wrote:
>
>> Author: nicholas
>> Date: Thu Feb  7 20:38:30 2013
>> New Revision: 174694
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=174694&view=rev
>> Log:
>> Fix test failure by making sure this file isn't identical to any other
>> file
>> included in the same test. Clang gets confused about whether it's already
>> built
>> a module for this file, when running on a content-addressible filesystem.
>>
>> Modified:
>>
>> cfe/trunk/test/Modules/Inputs/HasSubModules.framework/Frameworks/Sub.framework/PrivateHeaders/SubPriv.h
>>
>> Modified:
>> cfe/trunk/test/Modules/Inputs/HasSubModules.framework/Frameworks/Sub.framework/PrivateHeaders/SubPriv.h
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Modules/Inputs/HasSubModules.framework/Frameworks/Sub.framework/PrivateHeaders/SubPriv.h?rev=174694&r1=174693&r2=174694&view=diff
>>
>> ==============================================================================
>> ---
>> cfe/trunk/test/Modules/Inputs/HasSubModules.framework/Frameworks/Sub.framework/PrivateHeaders/SubPriv.h
>> (original)
>> +++
>> cfe/trunk/test/Modules/Inputs/HasSubModules.framework/Frameworks/Sub.framework/PrivateHeaders/SubPriv.h
>> Thu Feb  7 20:38:30 2013
>> @@ -1 +1,2 @@
>>  #include <Sub/Types.h>
>> +// Private
>>
>
> Maybe but the filename here and some explanation? The next person to touch
> this will probably benefit from that?
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130212/28ae6437/attachment.html>


More information about the cfe-commits mailing list