Patch to accept over-qualified constructor in MSVC emulation mode

Jason Haslam jason.haslam at gmail.com
Fri Feb 8 14:44:53 PST 2013


On Feb 8, 2013, at 3:25 PM, John McCall <rjmccall at apple.com> wrote:

> On Feb 8, 2013, at 12:29 PM, Jason Haslam <jason.haslam at gmail.com> wrote:
>> On Feb 8, 2013, at 12:32 PM, Dmitri Gribenko <gribozavr at gmail.com> wrote:
>>> On Wed, Feb 6, 2013 at 11:19 PM, Jason Haslam <jason.haslam at gmail.com> wrote:
>>>> MSVC accepts this:
>>>> 
>>>> class A {
>>>> A::A();
>>>> };
>>>> 
>>>> Clang accepts regular member functions with extra qualification as an MS extension, but not constructors.
>>> 
>>> Please also add a test that checks that we don't accept this in
>>> non-msext mode.  It should probably go into
>>> test/CXX/class/class.ctor/p1.cpp.
>> 
>> Sure.
> 
> Approved.

Thanks. Can someone commit this for me? I don't have commit access.

Jason





More information about the cfe-commits mailing list