[PATCH] Reduce CXString abuse

Argyrios Kyrtzidis akyrtzi at gmail.com
Thu Feb 7 09:48:41 PST 2013


LGTM!

On Feb 7, 2013, at 7:37 AM, Dmitri Gribenko <gribozavr at gmail.com> wrote:

> On Sat, Feb 2, 2013 at 1:14 AM, Dmitri Gribenko <gribozavr at gmail.com> wrote:
>> As suggested on IRC, ContainerUSR is not really a CXString, but it
>> should own the underlying memory buffer.  Thus, it is better to change
>> the type to std::string.  This will not introduce extra copying
>> overhead, since the workaround that is being removed was already
>> making a copy.
> 
> Hi Argyrios,
> 
> Can you please review this patch, since Doug is apparently busy?
> 
> Dmitri
> 
> -- 
> main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
> (j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/





More information about the cfe-commits mailing list