[PATCH] Pull Lexer's CharInfo table out for general use throughout Clang

Dmitri Gribenko gribozavr at gmail.com
Wed Feb 6 04:03:56 PST 2013


  LGTM.


================
Comment at: unittests/Basic/CharInfoTest.cpp:16-18
@@ +15,5 @@
+
+namespace {
+
+class CharInfoTest : public ::testing::Test {};
+
----------------
You don't really need this class and the namespace.  Just do `TEST(..., ...) {...`


http://llvm-reviews.chandlerc.com/D363



More information about the cfe-commits mailing list