LGTM. ================ Comment at: unittests/Basic/CharInfoTest.cpp:16-18 @@ +15,5 @@ + +namespace { + +class CharInfoTest : public ::testing::Test {}; + ---------------- You don't really need this class and the namespace. Just do `TEST(..., ...) {...` http://llvm-reviews.chandlerc.com/D363