[PATCH] Pull Lexer's CharInfo table out for general use throughout Clang
Jordan Rose
jordan_rose at apple.com
Tue Feb 5 15:37:01 PST 2013
Address comments:
- Use `!= 0` instead of `? true : false`.
- Add CHAR_XLETTER to distinguish hex digits from other letters.
- Use unit tests to validate the CharInfo table, instead of a static validation function in Lexer.
Hi rsmith, bkramer, gribozavr, joerg,
http://llvm-reviews.chandlerc.com/D363
CHANGE SINCE LAST DIFF
http://llvm-reviews.chandlerc.com/D363?vs=865&id=892#toc
Files:
include/clang/Basic/CharInfo.h
lib/Basic/CMakeLists.txt
lib/Basic/CharInfo.cpp
lib/Lex/Lexer.cpp
unittests/Basic/CMakeLists.txt
unittests/Basic/CharInfoTest.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D363.2.patch
Type: text/x-patch
Size: 25496 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130205/46202324/attachment.bin>
More information about the cfe-commits
mailing list