[cfe-commits] [PATCH]OpenCL samplers

[Benyei, Guy]

Hi Tanya,
I've added a specific test to check the SemaOverload part.
The goal of the SemaOverload part is to enable the usage of constant and private address space samplers in overloaded functions. The OpenCL spec allows the usage of both, and they are actually the same.

Please review.

Thanks
   Guy Benyei
[email_signature_guy_new2]

From: Tanya Lattner [mailto:lattner at apple.com]
Sent: Thursday, January 31, 2013 03:18
To: Benyei, Guy
Cc: cfe-commits at cs.uiuc.edu
Subject: Re: [cfe-commits] [PATCH]OpenCL samplers

Overall, this patch looks ok to me.

I'm not familiar enough with the changes in lib/SemaOverload though to know if that is correct. Do you have a test case that is covering that case?

Thanks,
Tanya

On Jan 28, 2013, at 5:54 AM, "Benyei, Guy" <guy.benyei at intel.com<mailto:guy.benyei at intel.com>> wrote:


Hi Tanya,
Here is the sampler part.

Please review.

<image001.png>

From: Tanya Lattner [mailto:lattner at apple.com]
Sent: Saturday, January 26, 2013 02:19
To: Benyei, Guy
Cc: cfe-commits at cs.uiuc.edu<mailto:cfe-commits at cs.uiuc.edu>
Subject: Re: [cfe-commits] [PATCH]OpenCL samplers

Guy,

I would break this out into separate patches. One for the sampler type, one for restriction checking, and the fix for event_t.

-Tanya

On Jan 24, 2013, at 12:37 PM, "Benyei, Guy" <guy.benyei at intel.com<mailto:guy.benyei at intel.com>> wrote:



Hi all,
Attached a patch that implements the OpenCL sampler_t type in Clang. The sampler_t type is represented by the i32 LLVM type.
Added also some restriction checking for images and samplers, and a fix for the event_t implementation that enables using zero events with function overloading.

Please review

     Thanks
          Guy Benyei

<image001.png>

<opencl_samplers.patch>

---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
_______________________________________________
cfe-commits mailing list
cfe-commits at cs.uiuc.edu<mailto:cfe-commits at cs.uiuc.edu>
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

<opencl_samplers2.patch>

---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130205/4009e08f/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.png
Type: image/png
Size: 24800 bytes
Desc: image001.png
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130205/4009e08f/attachment.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: opencl_samplers3.patch
Type: application/octet-stream
Size: 24195 bytes
Desc: opencl_samplers3.patch
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130205/4009e08f/attachment.obj>
-------------- next part --------------
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130205/4009e08f/attachment-0001.html>