[PATCH] Re-design the convenience interfaces on MatchFinder.

[Daniel Jasper]

  You forgot a few \p. Other than that, looks good.


================
Comment at: include/clang/ASTMatchers/ASTMatchFinder.h:137
@@ -136,2 +136,3 @@
 
-  /// \brief Finds all matches on the given \c Node.
+  /// \brief Calls the registered callbacks on all matches on the given \c Node.
+  ///
----------------
\p ?

================
Comment at: include/clang/ASTMatchers/ASTMatchFinder.h:167
@@ -160,1 +166,3 @@
 
+/// \brief Returns the results of matching \c Matcher on \c Node.
+///
----------------
\p?

================
Comment at: lib/ASTMatchers/ASTMatchFinder.cpp:470
@@ -469,1 +469,3 @@
 
+  // Matches all registered matchers on the given node and calls the
+  // result callback for every node that matches.
----------------
maybe "on \p Node" ...


http://llvm-reviews.chandlerc.com/D359

BRANCH
  clang-ast-matchers-match

ARCANIST PROJECT
  clang