[Review, -cxx-abi microsoft] Implement proper handling of virtual destructors (single-inheritance case)

[Timur Iskhodzhanov]

2013/1/28 Timur Iskhodzhanov <timurrrr at google.com>:
> Two problems:
> 1) I was optimistically running only the new tests and didn't notice
> I've broken one of my own earlier tests in the Clang sources. I'll fix
> that soon
>
> 2) CGM code has changed over the weekend, I'll have to rebase.
>
> I'll ping this thread with a new patch when I resolve these.
Here it is attached.
Sorry for the delay, the Windows build was broken a few times in the
interim and also my VS checkout was borked for some reason.

Please note that I had to change the test/CodeGenCXX/arm.cpp test
because I believe it is wrong :)
See the other e-mail thread for the details.

> 2013/1/25 Timur Iskhodzhanov <timurrrr at google.com>:
>> Hi John,
>>
>> Attached is a patch that allows me to pass all the single-inheritance
>> vdtor tests I've extracted while building and running Chromium.
>>
>> It includes changing the deleting destructor to take an implicit bool
>> parameter when compiling in the Microsoft ABI.
>> Can you please take a look?
>> See also http://llvm.org/bugs/show_bug.cgi?id=15058 for the details.
>>
>> The patch contains a couple of FIXMEs, I'd like to defer them for
>> later analysis if possible.
>>
>> Note that I had to adjust the EmitCXXMemberCall interface slightly; I
>> think generalizing "VTT" to "implicit parameter in general" should be
>> OK.
>>
>> Please tell me if I need to change anything.
>>
>> --
>> Timur Iskhodzhanov,
>> Google Russia
>
>
>
> --
> Timur Iskhodzhanov,
> Google Russia
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bug_15058_2.patch
Type: application/octet-stream
Size: 29183 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130129/35293289/attachment.obj>