[cfe-commits] r173586 - Attach any tag type's documentation to its typedef if

NAKAMURA Takumi geek4civic at gmail.com
Sat Jan 26 21:18:23 PST 2013


Fariborz, it seems it doesn't like @tparam in templates.
http://bb.pgr.jp/builders/clang-3stage-x86_64-linux/builds/832

...Takumi

2013/1/27 Fariborz Jahanian <fjahanian at apple.com>:
> Author: fjahanian
> Date: Sat Jan 26 14:49:30 2013
> New Revision: 173586
>
> URL: http://llvm.org/viewvc/llvm-project?rev=173586&view=rev
> Log:
> Attach any tag type's documentation to its typedef if
> latter does not have one of its own. // rdar://13067629
>
> Modified:
>     cfe/trunk/lib/AST/ASTContext.cpp
>     cfe/trunk/test/Index/annotate-comments-typedef.m
>
> Modified: cfe/trunk/lib/AST/ASTContext.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/ASTContext.cpp?rev=173586&r1=173585&r2=173586&view=diff
> ==============================================================================
> --- cfe/trunk/lib/AST/ASTContext.cpp (original)
> +++ cfe/trunk/lib/AST/ASTContext.cpp Sat Jan 26 14:49:30 2013
> @@ -431,9 +431,9 @@ comments::FullComment *ASTContext::getCo
>        // Attach enum's documentation to its typedef if latter
>        // does not have one of its own.
>        QualType QT = TD->getUnderlyingType();
> -      if (const EnumType *ET = QT->getAs<EnumType>())
> -        if (const EnumDecl *ED = ET->getDecl())
> -          if (comments::FullComment *FC = getCommentForDecl(ED, PP))
> +      if (const TagType *TT = QT->getAs<TagType>())
> +        if (const Decl *TD = TT->getDecl())
> +          if (comments::FullComment *FC = getCommentForDecl(TD, PP))
>              return cloneFullComment(FC, D);
>      }
>      return NULL;
>
> Modified: cfe/trunk/test/Index/annotate-comments-typedef.m
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Index/annotate-comments-typedef.m?rev=173586&r1=173585&r2=173586&view=diff
> ==============================================================================
> --- cfe/trunk/test/Index/annotate-comments-typedef.m (original)
> +++ cfe/trunk/test/Index/annotate-comments-typedef.m Sat Jan 26 14:49:30 2013
> @@ -28,3 +28,9 @@ enum E {
>  };
>  typedef enum E E_T;
>  // CHECK: TypedefDecl=E_T:[[@LINE-1]]:16 (Definition) FullCommentAsHTML=[<p class="para-brief"> Documentation for E </p>] FullCommentAsXML=[<Typedef file="{{[^"]+}}annotate-comments-typedef.m" line="[[@LINE-1]]" column="16"><Name>E</Name><USR>c:@E at E</USR><Declaration>typedef enum E E_T</Declaration><Abstract><Para> Documentation for E </Para></Abstract></Typedef>]
> +
> +/** Comment about Foo */
> +typedef struct {
> +         int iii;
> +        } Foo;
> +// CHECK: TypedefDecl=Foo:[[@LINE-1]]:11 (Definition) FullCommentAsHTML=[<p class="para-brief"> Comment about Foo </p>] FullCommentAsXML=[<Typedef file="{{[^"]+}}annotate-comments-typedef.m" line="[[@LINE-1]]" column="11"><Name><anonymous></Name><USR>c:@SA at Foo</USR><Declaration>typedef struct Foo Foo</Declaration><Abstract><Para> Comment about Foo </Para></Abstract></Typedef>]
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits




More information about the cfe-commits mailing list