[cfe-commits] r173135 - /cfe/trunk/lib/Driver/ToolChains.cpp

[Alexander Potapenko]

Hi Renato,
I've fixed the test in my next commit:
http://lab.llvm.org:8011/builders/clang-native-arm-cortex-a9/builds/4550

On Tue, Jan 22, 2013 at 5:33 PM, Renato Golin Linaro
<renato.golin at linaro.org> wrote:
> Hi Alexander,
>
> This commit broke the test: Driver/darwin-sanitizer-ld.c on ARM buildbots:
>
> http://lab.llvm.org:8011/builders/clang-native-arm-cortex-a9/builds/4549
>
> Looks like the name of the lib must also be updated...
>
> cheers,
> --renato
>
>
>
> On 22 January 2013 09:16, Alexander Potapenko <glider at google.com> wrote:
>>
>> Author: glider
>> Date: Tue Jan 22 03:16:03 2013
>> New Revision: 173135
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=173135&view=rev
>> Log:
>> [ASan] Link with the dynamic runtime on OS X
>> This patch changes the behavior of the -fsanitize=address flag, making it
>> use the dynamic runtime library (libclang_rt.asan_osx_dynamic.dylib) instead
>> of the static one. It also drops the CoreFoundation dependency, since the
>> dynamic runtime doesn't need it.
>>
>>
>> Modified:
>>     cfe/trunk/lib/Driver/ToolChains.cpp
>>
>> Modified: cfe/trunk/lib/Driver/ToolChains.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains.cpp?rev=173135&r1=173134&r2=173135&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/lib/Driver/ToolChains.cpp (original)
>> +++ cfe/trunk/lib/Driver/ToolChains.cpp Tue Jan 22 03:16:03 2013
>> @@ -339,12 +339,10 @@
>>        getDriver().Diag(diag::err_drv_clang_unsupported_per_platform)
>>          << "-fsanitize=address";
>>      } else {
>> -      AddLinkRuntimeLib(Args, CmdArgs, "libclang_rt.asan_osx.a", true);
>> +      AddLinkRuntimeLib(Args, CmdArgs,
>> "libclang_rt.asan_osx_dynamic.dylib", true);
>>
>> -      // The ASAN runtime library requires C++ and CoreFoundation.
>> +      // The ASAN runtime library requires C++.
>>        AddCXXStdlibLibArgs(Args, CmdArgs);
>> -      CmdArgs.push_back("-framework");
>> -      CmdArgs.push_back("CoreFoundation");
>>      }
>>    }
>>
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>



-- 
Alexander Potapenko
Software Engineer
Google Moscow