[cfe-commits] [llvm-commits] [patch] fp128 sint_to_fp folding fix

[Richard Smith]

Please move the default out of the switch. Otherwise, looks fine. Thanks
for the pch test!
On Jan 21, 2013 4:54 AM, "Tim Northover" <t.p.northover at gmail.com> wrote:

> Hi Richard,
>
> > The AST dumper is a bit of a special case. It's intended to be usable
> > by running Expr->dump() from a debugger, and consequently it does not
> > have access to the ASTContext.
>
> I thought it might be, which is why I stopped there.
>
> > If this isn't working out well, how about replacing the IsIEEE flag in
> > FloatingLiteralBitfields with a float kind enumeration?
>
> Now that seems to have worked better; thanks for the suggestion. I've
> attached the updated Clang patch, together with its LLVM counterpart
> for reference.
>
> Does it look reasonable to you?
>
> Tim.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130121/235db161/attachment.html>