[cfe-commits] [PATCH] Support for universal character names in identifiers

[Jordan Rose]

================
Comment at: lib/Lex/Lexer.cpp:1598
@@ -1597,3 +1693,3 @@
   char PrevCh = 0;
-  while (isNumberBody(C)) { // FIXME: UCNs in ud-suffix.
     CurPtr = ConsumeChar(CurPtr, Size, Result);
----------------
Jordan Rose wrote:
> Richard Smith wrote:
> > This FIXME still needs to be addressed, right?
> I'm not sure. Eli had this taken out in his initial patch, and certainly we now give the proper warning for using a UCN sans underscore in a ud-suffix. But I don't know if it actually works end-to-end yet. I'll double-check.
Looks like no. I started a bit of local work to merge all the identifier reading in LexNumericLiteral, LexUDSuffix, and LexIdentifier, but I guess it can just wait for a separate patch.


http://llvm-reviews.chandlerc.com/D312