[cfe-commits] PING: [PATCH, RFC] Fix PR14881 (complex integer promotion rules)

[Bill Schmidt]

Ping...

Seeking a review from a front-end person.  I think the changed logic is
pretty straightforward, but I mostly work in the back end and would
appreciate a quick glance.  Thanks!

Bill

On Wed, 2013-01-16 at 15:41 -0600, Bill Schmidt wrote:
> This patch addresses PR14881.
> 
> Prior to the patch, Clang does not properly promote types when a complex
> integer operand is combined with an integer via a binary operator, or when
> one is assigned to the other in either order.  This patch detects when
> promotion is needed (and permissible) and generates the necessary code.
> 
> I've included a rather extensive test case to exercise all the various
> cases, including signed and unsigned variants.  I believe that the necessary
> handling of signedness is already in place, and the generated code confirms
> this to my best understanding.  I hope that the test will run on all targets.
> I've assumed that no target has the same size operands for "char" and
> "long long," and that no target performs arithmetic on char operands without
> extending them to a larger format first.  If there are any targets for which
> this is not the case, the test case will need adjustment.  I'd appreciate
> any information about the validity of my assumptions before I turn the test
> loose on the world...
> 
> Thanks in advance for your review!
>