[cfe-commits] [PATCH] Formatter: Give '.' after ')' a smaller split penalty than ', '

[Daniel Jasper]

  Looks good. I might need to play around with this a bit, to be convince myself it is the "right" solution / penalty value. But it is a great idea.


================
Comment at: lib/Format/Format.cpp:623
@@ -622,1 +622,3 @@
+      if (Left.is(tok::r_paren))
+        return 10; // Should be smaller than tok::comma above.
       return 150;
----------------
Could you create the patches with a slightly larger (e.g. 10000 lines ;-)) context before uploading them to fabricator? This makes them much nicer to look at here.

If this still looks like my current HEAD, then the comment is slightly confusing as the penalty for a comma is set to 0. Maybe something like "Should be smaller than a comma nested deeper in parenthesis.".


http://llvm-reviews.chandlerc.com/D310