[cfe-commits] r172739 - in /cfe/trunk: lib/Analysis/PrintfFormatString.cpp test/FixIt/format-darwin.m test/FixIt/format.m

[Jordan Rose]

On Jan 17, 2013, at 13:04 , Dmitri Gribenko <gribozavr at gmail.com> wrote:

> Hi Jordan,
> 
> On Thu, Jan 17, 2013 at 8:47 PM, Jordan Rose <jordan_rose at apple.com> wrote:
>> Author: jrose
>> Date: Thu Jan 17 12:47:16 2013
>> New Revision: 172739
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=172739&view=rev
>> Log:
>> Format strings: correct signedness if already correcting width (%d,%u).
>> 
>> It is valid to do this:
>>  printf("%u", (int)x);
>> 
>> But if we see this:
>>  printf("%lu", (int)x);
>> 
>> ...our fixit should suggest %d, not %u.
> 
> Sorry, but it looks like this commit broke Linux/x86-64:
> 
> http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/422


I don't know why my check didn't catch these; I'm seeing them locally now too. Thanks, Dmitri.

Jordan