[cfe-commits] [PATCH] Added use-nullptr transform into cpp11-migrate tool

[Dmitri Gribenko]

================
Comment at: cpp11-migrate/UseNullptr/NullptrActions.h:40-41
@@ +39,4 @@
+
+
+
+
----------------
Extra empty lines.

================
Comment at: cpp11-migrate/UseNullptr/NullptrActions.cpp:44
@@ +43,3 @@
+  // Only VisitStmt is overridden as we shouldn't find other base AST types
+  // within a cast statement.
+  bool VisitStmt(Stmt *S) {
----------------
cast *expression*

================
Comment at: cpp11-migrate/UseNullptr/NullptrActions.cpp:80
@@ +79,3 @@
+  CastExpr *FirstCast;
+}; // end class CastSequenceVisitor
+
----------------
We don't use 'end something' comments except for namespaces.

================
Comment at: cpp11-migrate/UseNullptr/NullptrActions.cpp:33-35
@@ +32,5 @@
+/// (i.e. it has no explicit casts as an ancestor) where an implicit cast is
+/// nested within. However, there is no guarantee that only explicit casts
+/// exist between the found top-most explicit cast and the possibly more than
+/// one nested implicit cast. This visitor finds all cast sequences with an
+/// implicit cast to null within and creates a replacement.
----------------
Please add negative tests for these cases.


http://llvm-reviews.chandlerc.com/D295