[cfe-commits] r172320 - in /cfe/trunk/include/clang: AST/ ASTMatchers/ Analysis/Analyses/ Basic/ Lex/ Sema/ Serialization/ StaticAnalyzer/Core/ StaticAnalyzer/Core/PathSensitive/

[David Blaikie]

On Mon, Jan 14, 2013 at 11:17 AM, Dmitri Gribenko <gribozavr at gmail.com> wrote:
> On Mon, Jan 14, 2013 at 9:01 PM, Jordan Rose <jordan_rose at apple.com> wrote:
>>
>> On Jan 14, 2013, at 11:00 , Dmitri Gribenko <gribozavr at gmail.com> wrote:
>>
>>> On Mon, Jan 14, 2013 at 7:27 PM, Jordan Rose <jordan_rose at apple.com> wrote:
>>>>
>>>> On Jan 12, 2013, at 8:54 , Dmitri Gribenko <gribozavr at gmail.com> wrote:
>>>>
>>>>> Author: gribozavr
>>>>> Date: Sat Jan 12 10:54:37 2013
>>>>> New Revision: 172320
>>>>>
>>>>> URL: http://llvm.org/viewvc/llvm-project?rev=172320&view=rev
>>>>> Log:
>>>>> Add missing includes and forward declarations so that headers don't depend on
>>>>> other headers included before them.
>>>>
>>>> How did you discover these? Did you use a tool? Or did you just try to compile the headers on their own and see what broke?
>>>
>>> Something in between:
>>>
>>> $ find include/clang/ -name \*.h | parallel clang -fsyntax-only -x c++
>>> -D__STDC_CONSTANT_MACROS -D__STDC_LIMIT_MACROS -I include/ -I
>>> ../../include/ -I ../../../build-cmake-r+a/include/ -I
>>> ../../../build-cmake-r+a/tools/clang/include/ -fcolor-diagnostics
>>
>> This seems like a good thing for a spare buildbot to do.
>
> We can certainly use my buildbot host for this, too (it is mostly idle
> since buildmaster does not give it enough tasks; it is fast enough to
> build *every* revision).  But unfortunately to run this custom command
> we need to modify python code for buildmaster and there is no good way
> to test that code except for setting up another buildmaster.

I have a private buildmaster using the zorg repo setup if you want me
to run experiments for you - though usually Galina is pretty good
about doing that on the public buildmaster too (buildbot reconfig
fails cleanly if the python doesn't parse, at least).

But I'd rather see this added to the build system so people could
easily verify it pre-submit rather than waiting for the bots to find
it.