[cfe-commits] [PATCH 11/15] Fix Casting

[Dmitri Gribenko]

On Fri, Jan 11, 2013 at 10:57 PM, Argyrios Kyrtzidis <akyrtzi at gmail.com> wrote:
> On Jan 11, 2013, at 12:36 PM, Dmitri Gribenko <gribozavr at gmail.com> wrote:
>
>> On Fri, Jan 11, 2013 at 10:32 PM,  <dag at cray.com> wrote:
>>> <dag at cray.com> writes:
>>>
>>>> Argyrios Kyrtzidis <akyrtzi at gmail.com> writes:
>>>>
>>>>> Most of your fixes are in functions creating a CXCursor out of a
>>>>> subclass of Decl; the suggestion here is to add a new function and
>>>>> have the other's call it, e.g:
>>>>>
>>>>> CXCursor cxcursor::MakeCursorVariableRef(const VarDecl *Var, SourceLocation Loc,
>>>>>                                         CXTranslationUnit TU) {
>>>>>  return MakeDeclCursor(CXCursor_VariableRef, Var, Loc, TU);
>>>>> }
>>>>>
>>>>> which is good in general.
>>>>
>>>> Ah, I see.  I'll hold off on my patches then and wait for these fixes.
>>>
>>> That is, if someone else is going to do them.  I thought I saw some
>>> changes fly in for them but I was wrong, it was something else.
>>>
>>> Can someone let me know whether the suggested change is going to happen
>>> relatively soon?  These patches are holding up some of my work, which is
>>> to send some more stuff upstream.
>>
>> Here's a proposed patch to make CXCursor contain const void*.
>>
>> Argyrios and David, please review.
>
> That's a lot of const goodness :-)
> LGTM, thank you!

Thank you for the review!  Committed r172252, r172253.

Dmitri

-- 
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/