[cfe-commits] [PATCH 11/15] Fix Casting

Dmitri Gribenko gribozavr at gmail.com
Fri Jan 11 12:36:58 PST 2013


On Fri, Jan 11, 2013 at 10:32 PM,  <dag at cray.com> wrote:
> <dag at cray.com> writes:
>
>> Argyrios Kyrtzidis <akyrtzi at gmail.com> writes:
>>
>>> Most of your fixes are in functions creating a CXCursor out of a
>>> subclass of Decl; the suggestion here is to add a new function and
>>> have the other's call it, e.g:
>>>
>>> CXCursor cxcursor::MakeCursorVariableRef(const VarDecl *Var, SourceLocation Loc,
>>>                                          CXTranslationUnit TU) {
>>>   return MakeDeclCursor(CXCursor_VariableRef, Var, Loc, TU);
>>> }
>>>
>>> which is good in general.
>>
>> Ah, I see.  I'll hold off on my patches then and wait for these fixes.
>
> That is, if someone else is going to do them.  I thought I saw some
> changes fly in for them but I was wrong, it was something else.
>
> Can someone let me know whether the suggested change is going to happen
> relatively soon?  These patches are holding up some of my work, which is
> to send some more stuff upstream.

Here's a proposed patch to make CXCursor contain const void*.

Argyrios and David, please review.

Dmitri

-- 
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libclang-const-correctness-v1.patch
Type: application/octet-stream
Size: 28697 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130111/afdc8c9b/attachment.obj>


More information about the cfe-commits mailing list