[cfe-commits] [PATCH 07/15] Fix Cast

[Jordan Rose]

This looks fine.

I agree with everyone else that even one patch per file is a bit unwieldy to review. Sean suggested putting everything in a single patch, since it's all the same issue, and for something like this that might not be so bad. If you're looking for a little more precision, one patch per library group (libclang, StaticAnalyzer, Sema, etc) might not be a bad idea because it's likely one person is qualified to review the entirety of each patch. (Which is why I'm not confirming the rest of these, even though they're probably correct.)

The splitting up of patches into separate e-mails from your introduction is also something not usually done on this list. I get that sometimes it's better to have separate threads for separate patches, but I don't think it would have hurt in this case to have everything coalesced.

Thanks for fixing all of these!
Jordan


On Jan 10, 2013, at 11:12 , David Greene <dag at cray.com> wrote:

> 
> Properly use const_cast to fix a cast-away-const error.
> ---
> .../clang/lib/StaticAnalyzer/Core/ExprEngine.cpp   |    3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
> 
> <0007-Fix-Cast.patch>_______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits