[cfe-commits] [PATCH] Allow RefactoringTool to write to memory instead of always to disk

[Manuel Klimek]

  Ah, very nice :) (some minor nits)


================
Comment at: include/clang/Rewrite/Core/Rewriter.h:285
@@ -280,2 +284,3 @@
   buffer_iterator buffer_end() { return RewriteBuffers.end(); }
+  unsigned int getNumBuffers() { return RewriteBuffers.size(); }
 
----------------
This is not needed any more, right?

================
Comment at: include/clang/Tooling/Refactoring.h:127
@@ -126,4 +126,3 @@
 
-  /// \brief Returns a set of replacements. All replacements added during the
-  /// run of the tool will be applied after all translation units have been
-  /// processed.
+  ~RefactoringTool() {}
+
----------------
Any reason to put the empty destructor in here?

================
Comment at: include/clang/Tooling/Refactoring.h:163
@@ -147,2 +162,3 @@
 
+
 } // end namespace tooling
----------------
Was this intentional?


http://llvm-reviews.chandlerc.com/D273

BRANCH
  refactor-changes

ARCANIST PROJECT
  clang