[cfe-commits] r172212 - in /cfe/trunk: lib/Format/Format.cpp unittests/Format/FormatTest.cpp
Daniel Jasper
djasper at google.com
Fri Jan 11 08:09:04 PST 2013
Author: djasper
Date: Fri Jan 11 10:09:04 2013
New Revision: 172212
URL: http://llvm.org/viewvc/llvm-project?rev=172212&view=rev
Log:
Correct spacing around new and delete.
This fixes llvm.org/PR14913.
Before: A *a = new(placement) A;
After: A *a = new (placement) A;
Modified:
cfe/trunk/lib/Format/Format.cpp
cfe/trunk/unittests/Format/FormatTest.cpp
Modified: cfe/trunk/lib/Format/Format.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Format/Format.cpp?rev=172212&r1=172211&r2=172212&view=diff
==============================================================================
--- cfe/trunk/lib/Format/Format.cpp (original)
+++ cfe/trunk/lib/Format/Format.cpp Fri Jan 11 10:09:04 2013
@@ -1063,7 +1063,8 @@
return CurrentLineType == LT_ObjCDecl || Left.is(tok::kw_if) ||
Left.is(tok::kw_for) || Left.is(tok::kw_while) ||
Left.is(tok::kw_switch) || Left.is(tok::kw_return) ||
- Left.is(tok::kw_catch);
+ Left.is(tok::kw_catch) || Left.is(tok::kw_new) ||
+ Left.is(tok::kw_delete);
}
if (Left.is(tok::at) &&
Right.FormatTok.Tok.getObjCKeywordID() != tok::objc_not_keyword)
Modified: cfe/trunk/unittests/Format/FormatTest.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/Format/FormatTest.cpp?rev=172212&r1=172211&r2=172212&view=diff
==============================================================================
--- cfe/trunk/unittests/Format/FormatTest.cpp (original)
+++ cfe/trunk/unittests/Format/FormatTest.cpp Fri Jan 11 10:09:04 2013
@@ -980,6 +980,13 @@
verifyFormat("void operator delete[](void *ptr);");
}
+TEST_F(FormatTest, UnderstandsNewAndDelete) {
+ verifyFormat("A *a = new A;");
+ verifyFormat("A *a = new (placement) A;");
+ verifyFormat("delete a;");
+ verifyFormat("delete (A *)a;");
+}
+
TEST_F(FormatTest, UnderstandsUsesOfStarAndAmp) {
verifyFormat("int *f(int *a) {}");
verifyFormat("f(a, *a);");
More information about the cfe-commits
mailing list