[cfe-commits] r172087 - in /cfe/trunk: test/TableGen/ test/TableGen/DiagnosticBase.inc test/TableGen/anonymous-groups.td test/TableGen/lit.local.cfg test/TableGen/tg-fixits.td utils/TableGen/ClangDiagnosticsEmitter.cpp

Jordan Rose jordan_rose at apple.com
Thu Jan 10 18:39:12 PST 2013


On Jan 10, 2013, at 17:44 , Jordan Rose <jordan_rose at apple.com> wrote:

> 
> On Jan 10, 2013, at 16:38 , Dmitri Gribenko <gribozavr at gmail.com> wrote:
> 
>> Fixed up the test in r172152.
>> 
>> http://llvm.org/bugs/show_bug.cgi?id=14910
> 
> Sorry, this is wrong. The test is correct on OS X (and presumably Windows as well). I'm working on another patch that just bans multibyte characters rather than checking column widths.

I got my commits backwards, but the original test is restored in r172163 and then the SourceMgr side was fixed in r172164. It bothers me that Clang is getting this wrong.

Jordan



More information about the cfe-commits mailing list