[cfe-commits] [PATCH] [patch] Formatter: Put spaces in ObjC method declarations in the right place for Google style
Nico Weber
thakis at chromium.org
Thu Jan 10 15:07:12 PST 2013
On Thu, Jan 10, 2013 at 3:03 PM, Daniel Jasper <djasper at google.com> wrote:
>
> Looks good.
Thanks!
>
>
> ================
> Comment at: lib/Format/Format.cpp:111
> @@ -109,2 +110,3 @@
> LLVMStyle.ObjCSpaceBeforeProtocolList = true;
> + LLVMStyle.ObjCSpaceBeforeReturnType = true;
> return LLVMStyle;
> ----------------
> So this controls both, whether there is a space before the return type and whether there is a space after the return type. Could we have style guides requiring other combinations?
Since it's syntactically valid, it's almost certain that there's some
code out there that has spaces in both or neither places. But it
should be easy to add another variable if clang-format ever wants to
support more styles.
More information about the cfe-commits
mailing list