[cfe-commits] r172110 - in /cfe/trunk: lib/Format/Format.cpp unittests/Format/FormatTest.cpp

Nico Weber thakis at chromium.org
Thu Jan 10 13:45:29 PST 2013


On Thu, Jan 10, 2013 at 1:43 PM, Jordan Rose <jordan_rose at apple.com> wrote:

> Looks like spaces are correct for @synthesize:
>
>
> https://developer.apple.com/library/mac/documentation/Cocoa/Conceptual/ProgrammingWithObjectiveC/EncapsulatingData/EncapsulatingData.html#//apple_ref/doc/uid/TP40011210-CH5-SW6
>
> @implementation YourClass
>
> @synthesize propertyName = instanceVariableName;
>
> ...
>
> @end
>
>
>
https://developer.apple.com/library/mac/#documentation/Cocoa/Conceptual/CodingGuidelines/Articles/NamingIvarsAndTypes.htmlhas

@synthesize showsTitle=_showsTitle;

though :-)


> Thanks for checking,
> Jordan
>
>
> On Jan 10, 2013, at 13:30 , Nico Weber <nicolasweber at gmx.de> wrote:
>
> Author: nico
> Date: Thu Jan 10 15:30:42 2013
> New Revision: 172110
>
> URL: http://llvm.org/viewvc/llvm-project?rev=172110&view=rev
> Log:
> Formatter: No spaces around '=' in @property lines.
>
> Before:
> @property(assign, getter = isEditable) BOOL editable;
>
> Now:
> @property(assign, getter=isEditable) BOOL editable;
>
> It'd be nice if some Apple person could let me know if spaces are preferred
> around '=' in @synthesize lines (see FIXME in the test).
>
>
> Modified:
>    cfe/trunk/lib/Format/Format.cpp
>    cfe/trunk/unittests/Format/FormatTest.cpp
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130110/6f2ea438/attachment.html>


More information about the cfe-commits mailing list