[cfe-commits] [PATCH] Remove 'PrintInstantiation' feature from DeclPrinter

[Richard Trieu]

Dmitri,

I don't understand your reasons for removing this code.  It was
specifically added so that template instantiations would be outputted with
-ast-dump.  Why do you consider printing instantiations misleading?

Richard.

On Mon, Jan 7, 2013 at 11:41 AM, Dmitri Gribenko <gribozavr at gmail.com>wrote:

> Hello,
>
> The attached patch removes the 'PrintInstantiation' feature from
> DeclPrinter.  The motivation is that it does not actually belong to
> the DeclPrinter and causes '-ast-print' to produce misleading results
> (printing the code for implicit instantiations).
>
> @Richard: CC'ing you since you added this feature in r136306.
>
> Dmitri
>
> --
> main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
> (j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130107/23bc5e7a/attachment.html>