[cfe-commits] r171724 - in /cfe/trunk: lib/Format/Format.cpp unittests/Format/FormatTest.cpp

[Daniel Jasper]

Yes. We do not explicitly check for "= 0" but just don't break after the
equals in virtual function declarations in general.


On Mon, Jan 7, 2013 at 6:24 PM, Jordan Rose <jordan_rose at apple.com> wrote:

> Does the same behavior apply to "= delete" and "= default"? I'm not sure
> what the prevailing style is there, but it seems like a reasonable thing
> for consistency.
>
> Jordan
>
>
> On Jan 7, 2013, at 2:48 , Daniel Jasper <djasper at google.com> wrote:
>
> > Author: djasper
> > Date: Mon Jan  7 04:48:50 2013
> > New Revision: 171724
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=171724&view=rev
> > Log:
> > Do not break before "0" in pure virtual function declarations.
> >
> > Before:
> > virtual void write(ELFWriter *writer, OwningPtr<FileOutputBuffer>
> &buffer) =
> >    0
> >
> > After:
> > virtual void write(ELFWriter *writerrr,
> >                   OwningPtr<FileOutputBuffer> &buffer) = 0;
> >
> > This addresses llvm.org/PR14815.
> >
> > To implement this I introduced a line type during parsing and moved the
> > definition of TokenType out of the struct for increased readability.
> > Should have done the latter in a separate patch, but it would be hard to
> > pull apart now.
> >
> > Modified:
> >    cfe/trunk/lib/Format/Format.cpp
> >    cfe/trunk/unittests/Format/FormatTest.cpp
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130107/fe2cac8d/attachment.html>