[cfe-commits] [llvm-commits] The AArch64 LLVM (& Clang) target

[Dmitri Gribenko]

On Mon, Jan 7, 2013 at 2:57 PM, Tim Northover <Tim.Northover at arm.com> wrote:
> I now finally have permission to start upstreaming the long-delayed backend
> for
> ARM's new 64-bit architecture, AArch64.
>
> In summary, we're proposing this backend for inclusion into LLVM; first as an
> experimental target, but with a view to being fully supported as soon as
> possible.

+/// UnknownPadding - Return the worst case padding that could result from
+/// unknown offset bits.  This does not include alignment padding caused by
+/// known offset bits.
+///
+/// @param LogAlign log2(alignment)
+/// @param KnownBits Number of known low offset bits.
+static inline unsigned UnknownPadding(unsigned LogAlign, unsigned KnownBits) {

When adding new code, please follow the new guidelines about doxygen
documentation: don't duplicate function and class names in the
comment.  Thank you.

+    /// __builtin_va_list as defind by the AArch64 ABI
+    /// http://infocenter.arm.com/help/topic/com.../IHI0055A_aapcs64.pdf

The link is broken.  Please also add this useful link to
llvm/docs/CompilerWriterInfo.rst

+++ b/test/Driver/aarch64-features.c
@@ -0,0 +1,5 @@
+// RUN: %clang -target aarch64-none-linux-gnu -### %s -fsyntax-only 2> %t
+// RUN: grep fno-signed-char %t

Please rewrite with FileCheck.

Dmitri

-- 
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/