[cfe-commits] [PATCH] Port loop-convert into cpp11-migrate

[Manuel Klimek]

Argh, sorry for the confusion, I'll never get used to llvm's AllCaps style
for variables :)


On Thu, Jan 3, 2013 at 4:51 PM, Vane, Edwin <edwin.vane at intel.com> wrote:

> TransformManager is of type 'Transforms' and Transforms.h and
> Transforms.cpp are both present in the diff. Although, I like the name
> TransformManager better so maybe I should rename the class just to
> differentiate it from 'Transform' by more than just an 's'?
>
> Everything under LoopConvert is a copy except LoopConvert.h and
> LoopConvert.cpp. LoopConvert.cpp comes mostly from
> loop-convert/LoopConvert.cpp just with simplifications due to the new
> location in a class. Actually if you dir-diffed loop-convert and
> cpp11-migrate/LoopConvert you would see exactly the changes I made. There
> were a few stylistic things I improved.
>
> -----Original Message-----
> From: Manuel Klimek [mailto:klimek at google.com]
> Sent: Thursday, January 03, 2013 10:29 AM
> To: klimek at google.com; silvas at purdue.edu; Vane, Edwin
> Cc: cfe-commits at cs.uiuc.edu
> Subject: Re: [PATCH] Port loop-convert into cpp11-migrate
>
>
>   Is the TransformManager implementation missing from the diff?
>
>   Also, can you point out which files are pure copies, so I know I don't
> need to re-review them? Thanks!
>
> http://llvm-reviews.chandlerc.com/D251
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130103/9d6ccae7/attachment.html>