[cfe-commits] Patch for bug 14744

[David Blaikie]

On Wed, Jan 2, 2013 at 9:40 AM, Anshuman Dasgupta
<adasgupt at codeaurora.org> wrote:
> Krzysztof,
>
> Looks good. I'll wait for David to review before committing.

LGTM - though we usually test with clang -cc1 where possible, so I'd
ask that you change the RUN line of your test to:

// RUN: %clang_cc1 -emit-llvm -triple hexagon-unknown-unknown %s -S -o /dev/null

& adding back in the -o /dev/null so we don't create unnecessary
temporary files. As far as I understand it, the test running
infrastructure (lit) has the necessary smarts to translate the use of
/dev/null to something appropriate on each platform. If you look
around at the regression test suite you'll find many other tests using
/dev/null for output.

Thanks,
- David

>
> -Anshu
>
>
> ---
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
> The Linux Foundation
>
>
> On 1/2/2013 11:25 AM, Krzysztof Parzyszek wrote:
>
> On 1/2/2013 11:22 AM, Krzysztof Parzyszek wrote:
>
>
> Hopefully the last change:
> - renamed the testcase: backend->target,
> - removed "-o /dev/null", as it would likely not work well on Windows
> (and other non-unixy systems).
>
>
> Ugh! *facepalm*
> Sorry about that.
>
> -Krzysztof
>
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>