[cfe-commits] Patch for bug 14744

[Krzysztof Parzyszek]

On 1/1/2013 5:43 PM, Dmitri Gribenko wrote:
> On Wed, Jan 2, 2013 at 12:54 AM, Krzysztof Parzyszek
> <kparzysz at codeaurora.org> wrote:
>> On 1/1/2013 4:28 PM, Dmitri Gribenko wrote:
>>>
>>> On Wed, Jan 2, 2013 at 12:07 AM, Krzysztof Parzyszek
>>> <kparzysz at codeaurora.org> wrote:
>>>>
>>>> I think I sent it to the wrong list the first time.
>>>> Could someone review and commit if ok?
>>>
>>>
>>> Is it possible to add a test for this?
>>
>> Certainly.  Not sure if it's very meaningful though.  Let me know what you
>> think.
>
> Should this test include
> // REQUIRES: hexagon-registered-target
> so that it is properly disabled when hexagon target is not compiled?
>
> IIRC, a translation unit without an external definitions is not valid.
>
> This test could also have a better name -- something about "simple-tu".
>
> Although this seems trivial, I don't think I can LGTM this patch. (I
> don't know about Hexagon a lot)
>
> In general we don't have -c tests, except for
> tools/clang/test/CodeGenCXX/vtable-debug-info.cpp.  This test
> should've caught this bug, shouldn't it?
>

"make test" generates over 800 failures due to this bug.  Like I said 
earlier, I'm not sure if having a testcase to test this bug adds much, 
since it will be exposed by anything that you try to compile on Hexagon.

-Krzysztof


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, 
hosted by The Linux Foundation