[cfe-commits] [PATCH] [libcxx][CMake] Fix c++ abi library configuration on Linux.

[Michael Spencer]

================
Comment at: CMakeLists.txt:71
@@ -68,2 +70,3 @@
+  set(LIBCXX_LIBSUPCXX_INCLUDE_PATHS "${LIBCXX_LIBSUPCXX_INCLUDE_PATHS}" CACHE STRINGS
       "Paths to libsupc++ include directories. Separate by system separator")
   set(LIBCXX_CXX_ABI_LIBRARIES stdc++)
----------------
Saleem Abdulrasool wrote:
> Can you update the string to reflect reality please?  "Separate by semicolons".
Fixed.

================
Comment at: CMakeLists.txt:81
@@ -77,1 +80,3 @@
       )
+  # Create include directories.
+  file(MAKE_DIRECTORY "${CMAKE_BINARY_DIR}/include")
----------------
Saleem Abdulrasool wrote:
> I'd rather see this moved into the for loop below around L109.
> 
>     if (NOT EXISTS "${CMAKE_BINARY_DIR}/include/${dstdir}")
>       file(MAKE_DIRECTORY "${CMAKE_BINARY_DIR}/include/${dstdir}")
>     endif()
This is more complicated, and won't actually work.

  file(MAKE_DIRECTORY "${CMAKE_BINARY_DIR}/include")

has to be done first.


http://llvm-reviews.chandlerc.com/D238