[cfe-commits] [PATCH] Format inline namespaces

[Daniel Jasper]

The patch looks good to me. Thank you!


On Sun, Dec 30, 2012 at 8:19 PM, Sebastian Redl <
sebastian.redl at getdesigned.at> wrote:

>
> On 30.12.2012, at 19:56, Dmitri Gribenko wrote:
>
> > On Sun, Dec 30, 2012 at 8:52 PM, Sebastian Redl
> > <sebastian.redl at getdesigned.at> wrote:
> >>
> >> On 30.12.2012, at 19:41, Dmitri Gribenko wrote:
> >>
> >>> Hello,
> >>>
> >>> The attached patch teaches the formatter about inline namespaces.
> >>> This changes formatting from:
> >>>
> >>> inline namespace X {
> >>> class A {
> >>> };
> >>> }
> >>>
> >>> to:
> >>>
> >>> inline namespace X {
> >>> class A {
> >>> };
> >>> }
> >>
> >> Seems like a strange coding convention. Do we really want this?
> >
> > This is how we currently format namespaces.  This patch is not about
> > whether we want indentation or not, it is about treating 'inline
> > namespace X' like a plain 'namespace X'.
>
> Ah, that's fine then. I was just surprised that inline namespaces would be
> treated differently than normal ones.
>
> Sebastian
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121230/4ba0bd72/attachment.html>