[cfe-commits] [PATCH] Minor cleanup

Nikola Smiljanić popizdeh at gmail.com
Fri Dec 28 16:41:38 PST 2012


DS parameter  has a default (null) value anyway, so there's no need for an if/else here.

DeclGroupPtrTy ParseDeclarationOrFunctionDefinition(
                                                  ParsedAttributesWithRange &attrs,
                                                  ParsingDeclSpec *DS = 0,
                                                  AccessSpecifier AS = AS_none);

http://llvm-reviews.chandlerc.com/D253

Files:
  lib/Parse/Parser.cpp

Index: lib/Parse/Parser.cpp
===================================================================
--- lib/Parse/Parser.cpp
+++ lib/Parse/Parser.cpp
@@ -760,11 +760,7 @@
   default:
   dont_know:
     // We can't tell whether this is a function-definition or declaration yet.
-    if (DS) {
       return ParseDeclarationOrFunctionDefinition(attrs, DS);
-    } else {
-      return ParseDeclarationOrFunctionDefinition(attrs);
-    }
   }
 
   // This routine returns a DeclGroup, if the thing we parsed only contains a
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D253.1.patch
Type: text/x-patch
Size: 518 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121228/a6cb2d90/attachment.bin>


More information about the cfe-commits mailing list