[cfe-commits] [PATCH] [libcxx][CMake] Fix c++ abi library configuration on Linux.

[Saleem Abdulrasool]

================
Comment at: CMakeLists.txt:69
@@ -65,3 +68,3 @@
 
-if (${LIBCXX_CXX_ABI} STREQUAL "libsupc++")
-  set(LIBCXX_LIBSUPCXX_INCLUDE_PATHS "" CACHE STRINGS
+if ("${LIBCXX_CXX_ABI}" STREQUAL "libsupc++")
+  set(LIBCXX_LIBSUPCXX_INCLUDE_PATHS "${LIBCXX_LIBSUPCXX_INCLUDE_PATHS}" CACHE STRINGS
----------------
I believe the quoting is unnecessary.  The value is already being treated as a string.

================
Comment at: CMakeLists.txt:71
@@ -68,2 +70,3 @@
+  set(LIBCXX_LIBSUPCXX_INCLUDE_PATHS "${LIBCXX_LIBSUPCXX_INCLUDE_PATHS}" CACHE STRINGS
       "Paths to libsupc++ include directories. Separate by system separator")
   set(LIBCXX_CXX_ABI_LIBRARIES stdc++)
----------------
Can you update the string to reflect reality please?  "Separate by semicolons".

================
Comment at: CMakeLists.txt:81
@@ -77,1 +80,3 @@
       )
+  # Create include directories.
+  file(MAKE_DIRECTORY "${CMAKE_BINARY_DIR}/include")
----------------
I'd rather see this moved into the for loop below around L109.

    if (NOT EXISTS "${CMAKE_BINARY_DIR}/include/${dstdir}")
      file(MAKE_DIRECTORY "${CMAKE_BINARY_DIR}/include/${dstdir}")
    endif()


http://llvm-reviews.chandlerc.com/D238