[cfe-commits] Fix PR 11326: conflicting mabi between -mabi and -target options on ARM

[Rafael Espíndola]

On 26 December 2012 17:53, Weiming Zhao <weimingz at codeaurora.org> wrote:
> Hi Rafael,
>
> Thanks for the review.
> I'm attaching the patch which includes test case.

Thanks for adding a test for the warning. I think the patch still
needs a codegen patch that checks that the value passed to -mabi is
actually used.

On the implementation itself: Why do you need to patch the triple
instead of just changing the code using it to give preference to
Opts.ABI?

+      Opts.Triple = T.getTriple();

This just copies the triple back, no?

> Thanks,
> weiming

Cheers,
Rafael