[cfe-commits] r171011 - /cfe/trunk/lib/CodeGen/CGValue.h

[Dmitri Gribenko]

On Monday, December 24, 2012, Chandler Carruth wrote:

> Yes, i never knew why folks waited for this. It was trivially correct, and
> I've jsut been looking at other things.
>

I just don't touch code unless I am sure that I understand it.  Since you
changed both the function and the parameter name, documentation might have
become irrelevant, so the fix is not that obvious.

Dmitri


>
> On Sun, Dec 23, 2012 at 6:16 PM, NAKAMURA Takumi <geek4civic at gmail.com<javascript:_e({}, 'cvml', 'geek4civic at gmail.com');>
> > wrote:
>
>> > --- cfe/trunk/lib/CodeGen/CGValue.h (original)
>> > +++ cfe/trunk/lib/CodeGen/CGValue.h Sun Dec 23 19:48:48 2012
>> > @@ -290,7 +290,7 @@
>> >
>> >    /// \brief Create a new object to represent a bit-field access.
>> >    ///
>> > -  /// \param BaseValue - The base address of the bit-field sequence
>> this
>> > +  /// \param Addr - The base address of the bit-field sequence this
>> >    /// bit-field refers to.
>> >    /// \param Info - The information describing how to perform the
>> bit-field
>> >    /// access.
>>
>> Chandler, does it make sense?
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu <javascript:_e({}, 'cvml',
>> 'cfe-commits at cs.uiuc.edu');>
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>
>
>

-- 
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121224/6060e44e/attachment.html>