[cfe-commits] small cleanup patch for libc++

Chad Rosier mcrosier at apple.com
Fri Dec 21 16:13:36 PST 2012


Committed revision 170967. Thanks, Eitan.

 Chad

On Dec 21, 2012, at 3:05 PM, Eitan Adler <lists at eitanadler.com> wrote:

> Its obvious from the context that there isn't a need for the double
> initialization:
> 
> Index: src/locale.cpp
> ===================================================================
> --- src/locale.cpp	(revision 170950)
> +++ src/locale.cpp	(working copy)
> @@ -2641,7 +2641,6 @@ utf16be_to_ucs4_length(const uint8_t* frm, const u
>                        codecvt_mode mode = codecvt_mode(0))
> {
>     const uint8_t* frm_nxt = frm;
> -    frm_nxt = frm;
>     if (mode & consume_header)
>     {
>         if (frm_end-frm_nxt >= 2 && frm_nxt[0] == 0xFE && frm_nxt[1] == 0xFF)
> @@ -2774,7 +2773,6 @@ utf16le_to_ucs4_length(const uint8_t* frm, const u
>                        codecvt_mode mode = codecvt_mode(0))
> {
>     const uint8_t* frm_nxt = frm;
> -    frm_nxt = frm;
>     if (mode & consume_header)
>     {
>         if (frm_end-frm_nxt >= 2 && frm_nxt[0] == 0xFF && frm_nxt[1] == 0xFE)
> @@ -2869,7 +2867,6 @@ utf16be_to_ucs2_length(const uint8_t* frm, const u
>                        codecvt_mode mode = codecvt_mode(0))
> {
>     const uint8_t* frm_nxt = frm;
> -    frm_nxt = frm;
>     if (mode & consume_header)
>     {
>         if (frm_end-frm_nxt >= 2 && frm_nxt[0] == 0xFE && frm_nxt[1] == 0xFF)
> 
> 
> -- 
> Eitan Adler
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits




More information about the cfe-commits mailing list