[cfe-commits] r170826 - in /cfe/trunk: include/clang/Analysis/CallGraph.h lib/Analysis/CallGraph.cpp lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp test/Analysis/debug-CallGraph.c

Anna Zaks ganna at apple.com
Thu Dec 20 19:00:17 PST 2012


On Dec 20, 2012, at 5:47 PM, Jordan Rose <jordan_rose at apple.com> wrote:

> One comment for when this gets re-commited:
> 
>> 
>> +  llvm::ReversePostOrderTraversal<clang::CallGraph*> RPOT(&CG);
>> +  for (llvm::ReversePostOrderTraversal<clang::CallGraph*>::rpo_iterator
>> +         I = RPOT.begin(); I != RPOT.end(); ++I) {
> 
> Cache the end pointer here?
> 

Good catch. It was a copy and paste from the ReversePostOrderTraversal comment, so will change there as well.




More information about the cfe-commits mailing list